[PATCH] D63547: [AIX]Global Address Lowering

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added a comment.

Some initial comments.



================
Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:5080
+     assert(CModel != CodeModel::Tiny ||
+           CModel != CodeModel::Kernel &&
+               "PowerPC doesn't support tiny or kernel codemodels.");
----------------
Minor nit: Fix the spacing.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:5083
+    
+    // For 64-bit medium and large code model, we generate two instructions
+    // as described below. Otherwise for 64-bit small code model, we allow
----------------
Move this to after dealing with some initial 32-bit cases.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:5091
+    // Transforms the ISD::TOC_ENTRY node to a PPCISD::LWZtoc.
+    auto replaceWithLWZtoc = [this, dl](SDNode *TocEntry) {
+      SDValue GA = TocEntry->getOperand(0);
----------------
Put this into a `!isPPC64` block.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63547/new/

https://reviews.llvm.org/D63547