[PATCH] D65421: Make lit.py abort_now() kill the worker process more precisely

Dan Liew via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 29 16:01:34 PDT 2019


delcypher added a comment.

@porglezomp Just to add a little more context here killing processes in lit has been a source of trouble for me and is part of why I never landed https://reviews.llvm.org/D47210 . We don't have a mechanism for tracking all the processes spawned during tests and when I implemented the  `--timeout` flag I had to implement a hack where we try walk the process tree to kill all the processes spawned by a shell test.
Multiprocessing seems to complicate things because the parent process will just re-spawn a worker process if it's killed.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65421/new/

https://reviews.llvm.org/D65421





More information about the llvm-commits mailing list