[PATCH] D65421: Make lit.py abort_now() kill the worker process more precisely

Dan Liew via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 29 15:51:30 PDT 2019


delcypher added a comment.

@porglezomp I think killing the process group is the intention. Shell tests can spawn many child processes and we want to make sure they get killed when `abort_now()` gets called. If you just kill the worker process you won't kill the child processes spawned by shell tests. This could cause zombie processes to be left lying around. For this reason I don't think we can land this patch.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65421/new/

https://reviews.llvm.org/D65421





More information about the llvm-commits mailing list