[PATCH] D28855: [CMake] Copy per-component `required_libraries` into `LINK_COMPONENTS`. NFC.

[Chris Bieneman via Phabricator via llvm-commits]

beanz added inline comments.
Herald added a subscriber: s.egerton.


================
Comment at: llvm/lib/Analysis/CMakeLists.txt:1
+set(LLVM_LINK_COMPONENTS
+  BinaryFormat
----------------
It would be better to use the `LINK_COMPONENTS` parameter to `add_llvm_library` rather than setting this. CMake's variable scoping behavior is non-intuitive, which can lead to bugs.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D28855/new/

https://reviews.llvm.org/D28855