[PATCH] D28855: [CMake] Copy per-component `required_libraries` into `LINK_COMPONENTS`. NFC.

Tue Jul 23 16:36:33 PDT 2019

bryant marked an inline comment as done.
bryant added inline comments.

================
Comment at: llvm/utils/llvm-build/llvmlinkcomps.py:1
+from llvmbuild.main import LLVMProjectInfo
+from os import pardir, path
----------------
bryant wrote:
> sbc100 wrote:
> > Start script with `#!/usr/bin/env python`
> > 
> > Add  `from __future__ import print_function`?
> > 
> > Add a file-level docstring to say what this does?  When is this script supposed to run and by whom?
> > 
> This script was included into this differential only to illustrate how `LLVM_LINK_COMPONENTS` were mechanically added into CMakeLists , just in case there are correctness issues with the approach (I could spot any).
> 
> Do we really want it included with the final git check-in? My initial guess was not.
Correction: I could *not* spot any.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D28855/new/

https://reviews.llvm.org/D28855