[PATCH] D64802: [llvm-ar][test] Add tests failing on Darwin

[James Nagurne via Phabricator via llvm-commits]

JamesNagurne added a comment.

In D64802#1602758 <https://reviews.llvm.org/D64802#1602758>, @gbreynoo wrote:

> Hi James,
>
> From my understanding these has been resolving correctly as XFAIL's on upstream Darwin test machines and `XFAIL: darwin` is used in a few other lit tests. I do not know what cross compiling is tested on the build bots however.
>
> Firstly, does use of `XFAIL: system-darwin` instead of `XFAIL: darwin` fix this issue?
>
> Second can you run any of the llvm tests below on your machine and get the expected result? They all use `XFAIL: darwin`:
>
> - test\DebugInfo\Generic\empty.ll
> - test\DebugInfo\Generic\gmlt.test
> - test\ExecutionEngine\MCJIT\test-global-ctors.ll
> - test\ExecutionEngine\OrcMCJIT\test-global-ctors.ll
>
>   Finally I believe lit just uses the standard python commands to determine the platform, do the commands below give unexpected output?
>
>
>
>   import sys
>   import platform
>   print(platform.system())
>   print(sys.platform)
>
>
> Hopefully this will make finding the cause of the issue easier.  If anyone else has suggestions I would be happy to hear them.
>
> Thanks




In D64802#1602758 <https://reviews.llvm.org/D64802#1602758>, @gbreynoo wrote:

> Hi James,
>
> From my understanding these has been resolving correctly as XFAIL's on upstream Darwin test machines and `XFAIL: darwin` is used in a few other lit tests. I do not know what cross compiling is tested on the build bots however.
>
> Firstly, does use of `XFAIL: system-darwin` instead of `XFAIL: darwin` fix this issue?
>
> Second can you run any of the llvm tests below on your machine and get the expected result? They all use `XFAIL: darwin`:
>
> - test\DebugInfo\Generic\empty.ll
> - test\DebugInfo\Generic\gmlt.test
> - test\ExecutionEngine\MCJIT\test-global-ctors.ll
> - test\ExecutionEngine\OrcMCJIT\test-global-ctors.ll
>
>   Finally I believe lit just uses the standard python commands to determine the platform, do the commands below give unexpected output?
>
>
>
>   import sys
>   import platform
>   print(platform.system())
>   print(sys.platform)
>
>
> Hopefully this will make finding the cause of the issue easier.  If anyone else has suggestions I would be happy to hear them.
>
> Thanks


I had not considered system-darwin, and hadn't found it in my cursory look through the tests, though I now see where it gets added by the main LLVM lit config.py file.

XFAIL: system-darwin does fix the issue and marks the unexpected failure.

I think the main question here is if compiling llvm-ar on darwin causes the errors, or if compiling **for** darwin causes the errors.
I'm not sure of the functional differences between llvm-ar between x86_64-apple-darwin* and our arm-*-none-eabi. I'm running under the assumption that the archive format is agnostic of the target triple. If that's the case, then I believe the problem lies when llvm-ar is built and executed as a darwin-hosted tool, and the XFAIL should be system-darwin. Otherwise, it would be the case that our Arm implementation is exhibiting similar bugs to the darwin implementation, and our downstream copy should have "|| arm-*-none-eabi" in addition to "darwin".

Thanks for the response. I think we'll continue forward with the system-darwin approach unless more work is done on this front.

JB


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64802/new/

https://reviews.llvm.org/D64802