[PATCH] D64802: [llvm-ar][test] Add tests failing on Darwin

Owen Reynolds via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 26 09:44:59 PDT 2019


gbreynoo added a comment.

Hi James,

>From my understanding these has been resolving correctly as XFAIL's on upstream Darwin test machines and `XFAIL: darwin` is used in a few other lit tests. I do not know what cross compiling is tested on the build bots however.

Firstly, does use of `XFAIL: system-darwin` instead of `XFAIL: darwin` fix this issue?

Second can you run any of the llvm tests below on your machine and get the expected result? They all use `XFAIL: darwin`:

- test\DebugInfo\Generic\empty.ll
- test\DebugInfo\Generic\gmlt.test
- test\ExecutionEngine\MCJIT\test-global-ctors.ll
- test\ExecutionEngine\OrcMCJIT\test-global-ctors.ll

Finally I believe lit just uses the standard python commands to determine the platform, do the commands below give unexpected output?

  import sys
  import platform
  print(platform.system())
  print(sys.platform)

Hopefully this will make finding the cause of the issue easier.  If anyone else has suggestions I would be happy to hear them.

Thanks


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64802/new/

https://reviews.llvm.org/D64802





More information about the llvm-commits mailing list