[PATCH] D65214: [obj2yaml] - Report a error when unable to resolve a sh_link reference properly.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 26 03:42:51 PDT 2019


grimar added a comment.

In D65214#1602306 <https://reviews.llvm.org/D65214#1602306>, @jhenderson wrote:

> In D65214#1602276 <https://reviews.llvm.org/D65214#1602276>, @grimar wrote:
>
> > James, do you have anything to add?
>
>
> Sorry, it's been a busy couple of days, and I ran out of time to look at this yesterday. Code change looks fine. Just a comment about the test.


No worries at all. I shouldn't have to ping you first of all, since LLVM policy suggest to do this once in a ~week.
(I just supposed you probably missed this comment for some reason, but there is definetely no need to rush in this or another patches I post).
Thanks for looking!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65214/new/

https://reviews.llvm.org/D65214





More information about the llvm-commits mailing list