[PATCH] D65214: [obj2yaml] - Report a error when unable to resolve a sh_link reference properly.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In D65214#1602276 <https://reviews.llvm.org/D65214#1602276>, @grimar wrote:

> James, do you have anything to add?


Sorry, it's been a busy couple of days, and I ran out of time to look at this yesterday. Code change looks fine. Just a comment about the test.



================
Comment at: test/tools/obj2yaml/elf-shlink.yaml:1
+## Check obj2yaml reports a proper error when unable to resolve
+## a sh_link reference in a regular section.
----------------
Should we have a test case to show that it can handle the elf-shlink value otherwise, or does that already exist?

If it already exists (or for some reason don't want it), perhaps you should rename this file elf-shlink-invalid.yaml.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65214/new/

https://reviews.llvm.org/D65214