[PATCH] D60390: FileCheck [10/12]: Add support for signed numeric values

[Alexander Richardson via Phabricator via llvm-commits]

arichardson added inline comments.


================
Comment at: llvm/lib/Support/FileCheck.cpp:131
+    // Op1 + Op2 > max int64_t.
+    if (Val1 > 0 && Val2 > 0 &&
+        Val1 > (std::numeric_limits<int64_t>::max() - Val2))
----------------
`llvm/include/llvm/Support/CheckedArithmetic.h` contains `llvm::checkedAdd`, `llvm::checkedSub`, `llvm::checkedAddUnsigned` and `llvm::checkedSubUnsigned`,  which should make this code much simpler.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60390/new/

https://reviews.llvm.org/D60390