[PATCH] D65241: [Polly][NFC][ScopBuilder] Move addUserAssumptions to ScopBuilder

[Dominik Adamski via Phabricator via llvm-commits]

domada added a comment.



In D65241#1601213 <https://reviews.llvm.org/D65241#1601213>, @Meinersbur wrote:

> [remark] Summary: `getRepresentingInvariantLoadSCEV` is already in the Scop class. Did you want to say changing its visibility to public?


Indeed. I want to make it public, because I think that it can be hellpful in the future if we want to remove friendship between ScopBuilder and Scop class. I have fixed summary.

In D65241#1601213 <https://reviews.llvm.org/D65241#1601213>, @Meinersbur wrote:

> [serious] `buildConditionSets` is now in the ScopInfo header and therefore made made accessible to the world. This is the opposite of the goal of moving things to ScopBuilder. Is this maybe an intermediate step before  also moving `buildConditionSets` to ScopBuilder?


Yes. It is an intermediate step. I have noticed, that `buildConditionSets` functions are also used by `buildDomains` which are still inside Scop class. In the next step I want to move `buildDomains` and `buildConditionSets` to ScopBuilder.

Maybe you can make a final review when I propose next patch with moved `buildDomains` functions?


Repository:
  rPLO Polly

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65241/new/

https://reviews.llvm.org/D65241