[PATCH] D65241: [Polly][NFC][ScopBuilder] Move addUserAssumptions to ScopBuilder

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added a comment.

[remark] Summary: `getRepresentingInvariantLoadSCEV` is already in the Scop class. Did you want to say changing its visibility to public?

[serious] `buildConditionSets` is now in the ScopInfo header and therefore made made accessible to the world. This is the opposite of the goal of moving things to ScopBuilder. Is this maybe an intermediate step before  also moving `buildConditionSets` to ScopBuilder?



================
Comment at: polly/include/polly/ScopInfo.h:1644
 };
+/// Build the conditions sets for the branch condition @p Condition in
+/// the @p Domain.
----------------
[nit] Missing space before doxygen comment


================
Comment at: polly/lib/Analysis/ScopInfo.cpp:2820
 isl::set Scop::getContext() const { return Context; }
+
 isl::space Scop::getParamSpace() const { return getContext().get_space(); }
----------------
[nit] Unrelated change


Repository:
  rPLO Polly

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65241/new/

https://reviews.llvm.org/D65241