[PATCH] D65214: [obj2yaml] - Report a error when unable to resolve a sh_link reference properly.

[George Rimar via Phabricator via llvm-commits]

grimar marked an inline comment as done.
grimar added inline comments.


================
Comment at: tools/obj2yaml/elf2yaml.cpp:380
+    if (!LinkSection)
+      return make_error<StringError>(
+          "unable to resolve sh_link reference in section '" + S.Name +
----------------
MaskRay wrote:
> So this prepends a message to the existing `toString(LinkSection.takeError())`.
> 
> LGTM, but let's see what james wants to say.
> So this prepends a message to the existing toString(LinkSection.takeError()).

Yeah, but the initial probem was in double `takeError()` call. As a result no error was reported at all.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65214/new/

https://reviews.llvm.org/D65214