[PATCH] D65214: [obj2yaml] - Report a error when unable to resolve a sh_link reference properly.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 25 01:39:35 PDT 2019


MaskRay added inline comments.


================
Comment at: tools/obj2yaml/elf2yaml.cpp:380
+    if (!LinkSection)
+      return make_error<StringError>(
+          "unable to resolve sh_link reference in section '" + S.Name +
----------------
So this prepends a message to the existing `toString(LinkSection.takeError())`.

LGTM, but let's see what james wants to say.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65214/new/

https://reviews.llvm.org/D65214





More information about the llvm-commits mailing list