[PATCH] D65255: [yaml2obj] Move core yaml2obj code into lib and include for use in unittests

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 25 01:35:56 PDT 2019


MaskRay added inline comments.


================
Comment at: llvm/lib/ObjectYAML/yaml2wasm.cpp:655
 
-int yaml2wasm(llvm::WasmYAML::Object &Doc, raw_ostream &Out) {
+int llvm::yaml::yaml2wasm(WasmYAML::Object &Doc, raw_ostream &Out) {
   WasmWriter Writer(Doc);
----------------
It is probably time to wrap these things in

```
namespace llvm {
namespace yaml {
...
}
}
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65255/new/

https://reviews.llvm.org/D65255





More information about the llvm-commits mailing list