[PATCH] D65255: [yaml2obj] Move core yaml2obj code into lib and include for use in unittests

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

Generally looks OK to me. Comments/questions are inlined.



================
Comment at: llvm/lib/ObjectYAML/yaml2obj.cpp:31
+      if (YIn.error())
+        error("yaml2obj: Failed to parse YAML file!");
+      if (Doc.Elf)
----------------
`yaml2obj` was a tool name. Should it still be printed?

Also seems it should not refer to file anymore, should it be "failed to parte YAML input"?
I guess that worth a unit test probably.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65255/new/

https://reviews.llvm.org/D65255