[PATCH] D65177: [WebAssembly] Set __tls_align to 1 when there is no TLS

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 24 11:25:02 PDT 2019


tlively accepted this revision.
tlively added inline comments.


================
Comment at: lld/test/wasm/no-tls.test:1
+RUN: llc -mattr=+bulk-memory -filetype=obj %p/Inputs/start.ll -o %t.o
+
----------------
quantum wrote:
> tlively wrote:
> > Why not have the input in this file?
> I did a test like this before and @sbc100 asked for it to be made into a .test file that uses one of the existing input files.
Please add a comment saying what this is meant to be testing. I don't think it will be clear just from the name and contents for future readers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65177/new/

https://reviews.llvm.org/D65177





More information about the llvm-commits mailing list