[PATCH] D65177: [WebAssembly] Set __tls_align to 1 when there is no TLS

[Guanzhong Chen via Phabricator via llvm-commits]

quantum marked 4 inline comments as done.
quantum added inline comments.


================
Comment at: lld/test/wasm/no-tls.test:1
+RUN: llc -mattr=+bulk-memory -filetype=obj %p/Inputs/start.ll -o %t.o
+
----------------
tlively wrote:
> Why not have the input in this file?
I did a test like this before and @sbc100 asked for it to be made into a .test file that uses one of the existing input files.


================
Comment at: lld/wasm/Driver.cpp:532
     WasmSym::tlsBase = createGlobalVariable("__tls_base", true);
     WasmSym::tlsSize = createGlobalVariable("__tls_size", false);
+    WasmSym::tlsAlign = createGlobalVariable("__tls_align", false, 1);
----------------
tlively wrote:
> May as well update these calls to explicitly pass zero as well, and make it nonoptional. I assume there are no other calls to this function elsewhere?
Done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65177/new/

https://reviews.llvm.org/D65177