[PATCH] D65191: [llvm-objcopy] Implement highlighting

[John Reagan via Phabricator via llvm-commits]

JohnReagan added a comment.

Do you have a design or spec for what you consider to be "syntax highlighting?"  From the early example you show for coloring literals, registers, etc., I don't see the benefit.  For the current output, you can tell literals from registers, right?  After all, the assembler is able to re-parse them in.

And in general, I dislike color markups in output as they always end up relying on some system/platform screen/color support.  For instance, I don't think your highlighting will work on my OpenVMS x86 system.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65191/new/

https://reviews.llvm.org/D65191