[PATCH] D65191: [llvm-objcopy] Implement highlighting

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 24 00:50:30 PDT 2019


MaskRay added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:335
 
+static cl::opt<bool> Highlight("highlight",
+                               cl::desc("Enable syntax highlighting"),
----------------
--color is a more common option name: ls, less, grep, zstd, etc

Can you investigate a bit if it is possible to have both --color and --color=when ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65191/new/

https://reviews.llvm.org/D65191





More information about the llvm-commits mailing list