[PATCH] D65138: [OCaml] Add LLVMInternalizePredicateBindings

[Timotej Kapus via Phabricator via llvm-commits]

kren1 marked an inline comment as done.
kren1 added inline comments.


================
Comment at: bindings/ocaml/transforms/ipo/llvm_ipo.mli:76
+    If predicate returns [true], that symbol is preserved.
+    NOT THREAD SAFE! *)
+val add_internalize_predicate
----------------
whitequark wrote:
> I don't think we make any claims of thread safety for any other API. Why a warning on this one?
I felt it's necessary to warn the user that the predicate is not passed by value, but its reference is stored in a global variable. This kind of seemed like the most concise way of saying that. Would you prefer it rephrased to more closely match the above or just removed?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65138/new/

https://reviews.llvm.org/D65138