[PATCH] D65138: [OCaml] Add LLVMInternalizePredicateBindings

whitequark via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 23 04:09:31 PDT 2019


whitequark added inline comments.


================
Comment at: bindings/ocaml/transforms/ipo/llvm_ipo.mli:76
+    If predicate returns [true], that symbol is preserved.
+    NOT THREAD SAFE! *)
+val add_internalize_predicate
----------------
I don't think we make any claims of thread safety for any other API. Why a warning on this one?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65138/new/

https://reviews.llvm.org/D65138





More information about the llvm-commits mailing list