[PATCH] D64987: [Object/ELF.h] - Improve testing of the fields in ELFFile<ELFT>::sections().
    James Henderson via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Mon Jul 22 09:32:33 PDT 2019
    
    
  
jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.
LGTM, with the one suggestion.
================
Comment at: include/llvm/Object/ELF.h:524
+        "invalid section header table offset (e_shoff = " +
+        Twine::utohexstr(SectionTableOffset) +
+        ") or invalid number of sections specified in the first section "
----------------
Prefix these hex numbers with "0x" to make it obvious that they are hex (it's not always obvious).
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64987/new/
https://reviews.llvm.org/D64987
    
    
More information about the llvm-commits
mailing list