[PATCH] D64987: [Object/ELF.h] - Improve testing of the fields in ELFFile<ELFT>::sections().

Mon Jul 22 04:40:50 PDT 2019

grimar added inline comments.

================
Comment at: test/Object/invalid.test:593
+  - Type: SHT_NULL
+    Size: 288230376151711744
----------------
jhenderson wrote:
> I think there's one more case to test, if possible: a very high e_shoff value (e.g. 0xfffffffffffffff), combined with a small number of section headers (e.g. 1).
> 
> This assumes it's possible in yaml2obj to explicitly specify an e_shoff field without affecting the file size (I can't remember if you added that ability).
I had to fix the e_shoff in `ELFYAML.h` to make this test, it had `uint16` type, but had to be `uint_X`

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64987/new/

https://reviews.llvm.org/D64987