[PATCH] D65093: [llvm-ar] Fix support for archives with members larger than 4GB

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 22 07:39:52 PDT 2019


MaskRay added inline comments.


================
Comment at: include/llvm/Object/Archive.h:224
+  /// Size field is 10 decimal digits long
+  static const uint64_t MaxMemberSize = 9999999999;
+
----------------
I am curious why you want to handle a file whose size is within [4294967296,9999999999] (4G is a bit unusual as a binary. But you don't allow it to be larger..).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65093/new/

https://reviews.llvm.org/D65093





More information about the llvm-commits mailing list