[PATCH] D65093: [llvm-ar] Fix support for archives with members larger than 4GB

[Owen Reynolds via Phabricator via llvm-commits]

gbreynoo created this revision.
gbreynoo added reviewers: MaskRay, rupprecht.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

llvm-ar outputs a strange error message when handling archives with members larger than 4GB due to not checking file size when passing the value as an unsigned 32 bit integer. This overflow issue caused malformed archives to be created.:

https://bugs.llvm.org/show_bug.cgi?id=38058

This change allows for members above 4GB and will error in a case that is over the formats size limit, a 10 digit decimal integer.


Repository:
  rL LLVM

https://reviews.llvm.org/D65093

Files:
  include/llvm/Object/Archive.h
  lib/Object/Archive.cpp
  lib/Object/ArchiveWriter.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65093.211092.patch
Type: text/x-patch
Size: 4483 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190722/8aa04a7f/attachment.bin>