[PATCH] D63847: [MC] Add MCInstrAnalysis::evaluateMemoryOperandAddress

Sun Jul 21 18:24:18 PDT 2019

seiya marked an inline comment as done.
seiya added inline comments.

================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86MCTargetDesc.cpp:531
+  const MCOperand &ScaleAmt = Inst.getOperand(MemOpStart + X86::AddrScaleAmt);
+  const MCOperand &Disp = Inst.getOperand(MemOpStart + X86::AddrDisp);
+  if (IndexReg.getReg() != 0 || ScaleAmt.getImm() != 1 || !Disp.isImm())
----------------
craig.topper wrote:
> Should we check that getReg returns 0 for the segment register operand?
Yes we should. Thanks.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63847/new/

https://reviews.llvm.org/D63847