[PATCH] D63713: Add error handling to the DataExtractor class

[Pavel Labath via Phabricator via llvm-commits]

labath added a comment.

In D63713#1591371 <https://reviews.llvm.org/D63713#1591371>, @probinson wrote:

> I have been reminded that there's also a desire to make DataExtractor work with 64-bit section sizes.  Maybe Cursor should use a 64-bit offset (i.e., size_t not uint32_t), and then migrating from non-Cursor to Cursor APIs will also do the 64-bit transition?  We need to bite that bullet at some point.  (I kind of expect y'all to say, no way do that later, which is fine; mainly I wanted to refresh that in our collective minds.)


That sounds like a good idea to me. It shouldn't complicate the DataExtractor implementation too much (it should be enough to make the `getU` & co. static functions templated also on the offset type), and since adopting the Cursor API will require changes to the code using the DataExtractor anyway, it will make it easier to check that the code is compatible with 64-bit offsets.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63713/new/

https://reviews.llvm.org/D63713