[PATCH] D63713: Add error handling to the DataExtractor class

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 18 06:30:14 PDT 2019


probinson added a comment.

I have been reminded that there's also a desire to make DataExtractor work with 64-bit section sizes.  Maybe Cursor should use a 64-bit offset (i.e., size_t not uint32_t), and then migrating from non-Cursor to Cursor APIs will also do the 64-bit transition?  We need to bite that bullet at some point.  (I kind of expect y'all to say, no way do that later, which is fine; mainly I wanted to refresh that in our collective minds.)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63713/new/

https://reviews.llvm.org/D63713





More information about the llvm-commits mailing list