[PATCH] D64837: [cmake] Convert the NATIVE llvm build process to be project agnostic

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 16 22:26:03 PDT 2019


smeenai added inline comments.


================
Comment at: cmake/modules/CrossCompile.cmake:58
         -DCMAKE_MAKE_PROGRAM="${CMAKE_MAKE_PROGRAM}"
         ${CROSS_TOOLCHAIN_FLAGS_${target_name}} ${CMAKE_SOURCE_DIR}
         -DLLVM_TARGET_IS_CROSSCOMPILE_HOST=TRUE
----------------
You'll wanna change this one to read from a project-specific cache variable too. You'll also wanna preserve backwards compatibility for the people using the old spelling.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64837/new/

https://reviews.llvm.org/D64837





More information about the llvm-commits mailing list