[PATCH] D64837: [cmake] Convert the NATIVE llvm build process to be project agnostic
Shoaib Meenai via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 16 22:26:01 PDT 2019
smeenai added a comment.
This just seems like it's replacing all instances of LLVM with `${CMAKE_PROJECT_NAME}`?
I think it'd be cleaner and more explicit to pass an additional project name parameter to `llvm_create_cross_target` instead of implicitly using `${CMAKE_PROJECT_NAME}`. There's some prior art for that, e.g. in https://reviews.llvm.org/diffusion/L/browse/llvm/trunk/cmake/modules/AddLLVM.cmake;366290$1009?as=source&blame=off
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64837/new/
https://reviews.llvm.org/D64837
More information about the llvm-commits
mailing list