[PATCH] D64814: [NFC]Change ADDIStocHA to ADDIStocHA8 to follow 64-bit naming convention

Sean Fertile via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 16 14:12:03 PDT 2019


sfertile added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/P9InstrResources.td:151
     (instregex "NEG(8)?$"),
-    (instregex "ADDI(S)?toc(HA|L)$"),
+    (instregex "ADDI(S)?toc(HA8|HA|L)$"),
     COPY,
----------------
jsji wrote:
> Do we have plan to add `ADDItocL8` as well? 
> Why not use `(8)?` so that we don't need to update this again for `ADDItocL8` ?
> Do we have plan to add ADDItocL8 as well? 

Not in the near term, although from what I understand of AIX we will need to add one if we add an option similar to XL's `-qtocdata` for 32-bit code.

> Why not use (8)? so that we don't need to update this again for ADDItocL8 ?
I think this is a good suggestion


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64814/new/

https://reviews.llvm.org/D64814





More information about the llvm-commits mailing list