[PATCH] D64814: [NFC]Change ADDIStocHA to ADDIStocHA8 to follow 64-bit naming convention
Jinsong Ji via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 16 13:17:21 PDT 2019
jsji added a comment.
Herald added a subscriber: wuzish.
Please also remember to add `[PowerPC]` to title for all powerpc related patches. Thanks.
Should also update one comments .
`lib/Target/PowerPC/PPCISelLowering.cpp:14316: // is that for large code model we have ADDISTocHa + LDtocL and for`
================
Comment at: llvm/lib/Target/PowerPC/P9InstrResources.td:151
(instregex "NEG(8)?$"),
- (instregex "ADDI(S)?toc(HA|L)$"),
+ (instregex "ADDI(S)?toc(HA8|HA|L)$"),
COPY,
----------------
Do we have plan to add `ADDItocL8` as well?
Why not use `(8)?` so that we don't need to update this again for `ADDItocL8` ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64814/new/
https://reviews.llvm.org/D64814
More information about the llvm-commits
mailing list