[PATCH] D64639: [FileCheck] Store line numbers as optional values

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre added inline comments.


================
Comment at: llvm/lib/Support/FileCheck.cpp:186
+  Optional<size_t> DefLineNumber = NumericVariable->getDefLineNumber();
+  if (!IsPseudo && DefLineNumber && LineNumber && *DefLineNumber == *LineNumber)
     return FileCheckErrorDiagnostic::get(
----------------
jhenderson wrote:
> Is the IsPseudo field here redundant now? Are there pseudo variables with a defined line number?
No indeed and even if there as it's irrelevant. What matters is whether the Definition line number is same the current line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64639/new/

https://reviews.llvm.org/D64639