[PATCH] D64639: [FileCheck] Store line numbers as optional values

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Looks good, aside from one question.



================
Comment at: llvm/lib/Support/FileCheck.cpp:186
+  Optional<size_t> DefLineNumber = NumericVariable->getDefLineNumber();
+  if (!IsPseudo && DefLineNumber && LineNumber && *DefLineNumber == *LineNumber)
     return FileCheckErrorDiagnostic::get(
----------------
Is the IsPseudo field here redundant now? Are there pseudo variables with a defined line number?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64639/new/

https://reviews.llvm.org/D64639