[PATCH] D64472: [llvm-readobj/llvm-readelf] - Report a warning instead of a error when dumping a broken dynamic section.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 11 04:39:39 PDT 2019


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with one suggestion.



================
Comment at: test/tools/llvm-readobj/elf-dynamic-malformed.test:12
+# WARN: warning: invalid section size (4) or entity size (16)
+# WARN-EMPTY:
+# WARN:      Symbols [
----------------
I'd be inclined to add `WARN-NEXT: File: ...` here to show the context of this warning.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64472/new/

https://reviews.llvm.org/D64472





More information about the llvm-commits mailing list