[PATCH] D64472: [llvm-readobj/llvm-readelf] - Report a warning instead of a error when dumping a broken dynamic section.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: test/tools/llvm-readobj/elf-dynamic-malformed.test:127
+# WARN-EMPTY: 
+# WARN-NEXT: warning: invalid section size (4) or entity size (16)
+# WARN-NEXT: ProgramHeaders [
----------------
jhenderson wrote:
> Why is there a warning here? I think it's where the dynamic table should be printed, in which case, please add a comment stating as such.
Yes, it is because of that. Added a comment.


================
Comment at: tools/llvm-readobj/llvm-readobj.cpp:383
   WithColor::warning(errs()) << Msg << "\n";
+  errs().flush();
 }
----------------
jhenderson wrote:
> I'm not sure this flush is needed, since errs() is unbuffered.
You're right. I forgot or didn't know that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64472/new/

https://reviews.llvm.org/D64472