[PATCH] D64501: [ARM][LowOverheadLoops] Correct offset checking

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 11 00:19:56 PDT 2019


samparker marked an inline comment as done.
samparker added inline comments.


================
Comment at: lib/Target/ARM/ARMLowOverheadLoops.cpp:211
+  }
+  if (Start->getOpcode() == ARM::t2WhileLoopStart &&
+      (BBUtils->getOffsetOf(Start) >
----------------
SjoerdMeijer wrote:
> I am wondering why here the opcode is checked (WLS), but why that is not necessary above for LE....
Because 'End' can only be LE, whereas 'Start' can be DLS or WLS, and DLS doesn't use an offset.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64501/new/

https://reviews.llvm.org/D64501





More information about the llvm-commits mailing list