[PATCH] D64501: [ARM][LowOverheadLoops] Correct offset checking
Sjoerd Meijer via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 10 08:37:31 PDT 2019
SjoerdMeijer added inline comments.
================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:12995
+ if (CC->getOpcode() == ISD::XOR || CC->getOpcode() == ISD::SETCC) {
+ if (CC->getOperand(0)->getOpcode() != ISD::INTRINSIC_W_CHAIN)
+ return SDValue();
----------------
just a nit, perhaps it reads easier if this is just this instead of a nested if:
if ((...XOR || ...SETCC) && CC->getOperand(0)->getOpcode() == ISD::INTRINSIC_W_CHAIN)
================
Comment at: lib/Target/ARM/ARMLowOverheadLoops.cpp:211
+ }
+ if (Start->getOpcode() == ARM::t2WhileLoopStart &&
+ (BBUtils->getOffsetOf(Start) >
----------------
I am wondering why here the opcode is checked (WLS), but why that is not necessary above for LE....
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64501/new/
https://reviews.llvm.org/D64501
More information about the llvm-commits
mailing list