[PATCH] D60243: [LSan][AArch64] Speed-up leak and address sanitizers on AArch64 for 48-bit VMA

[Sebastian Pop via llvm-commits]

Ping, the patch is ready to be reviewed, and I have addressed all the
comments from the past reviews.

Thanks,
Sebastian

On Tue, Jun 11, 2019, 5:09 PM Sebastian Pop via Phabricator via
llvm-commits <llvm-commits at lists.llvm.org> wrote:

> sebpop updated this revision to Diff 204177.
> sebpop added a comment.
>
> For some reason `asan/tests/asan_noinst_test.cc` is not compiled on `make
> check-asan` and that has exposed a compile error that was not triggered by
> the other tests:
>
>   sanitizer_double_allocator.h:30:11: error: use of non-static data member
> 'use_first_' of 'DoubleAllocator' from nested type 'DoubleAllocatorCache'
>         if (use_first_)
>             ^~~~~~~~~~
>
> The updated patch fixes this by accessing the non-static field of the
> enclosing class through a this pointer to one of the instances:
>
>   -      if (use_first_)
>   +      if (this->use_first_)
>
> The updated patch passes `check-all` with no new fails on aarch64-linux.
>
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D60243/new/
>
> https://reviews.llvm.org/D60243
>
> Files:
>   compiler-rt/lib/asan/asan_allocator.cc
>   compiler-rt/lib/asan/asan_allocator.h
>   compiler-rt/lib/asan/asan_stats.cc
>   compiler-rt/lib/asan/asan_stats.h
>   compiler-rt/lib/lsan/lsan_allocator.h
>   compiler-rt/lib/sanitizer_common/sanitizer_allocator.h
>   compiler-rt/lib/sanitizer_common/sanitizer_allocator_combined.h
>   compiler-rt/lib/sanitizer_common/sanitizer_allocator_primary32.h
>   compiler-rt/lib/sanitizer_common/sanitizer_allocator_primary64.h
>   compiler-rt/lib/sanitizer_common/sanitizer_double_allocator.h
>   compiler-rt/lib/sanitizer_common/tests/sanitizer_allocator_test.cc
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190710/42765ff9/attachment.html>