<div dir="auto"><div>Ping, the patch is ready to be reviewed, and I have addressed all the comments from the past reviews.</div><div dir="auto"><br></div><div dir="auto">Thanks,</div><div dir="auto">Sebastian<br><br><div class="gmail_quote" dir="auto"><div dir="ltr" class="gmail_attr">On Tue, Jun 11, 2019, 5:09 PM Sebastian Pop via Phabricator via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">sebpop updated this revision to Diff 204177.<br>
sebpop added a comment.<br>
<br>
For some reason `asan/tests/asan_noinst_test.cc` is not compiled on `make check-asan` and that has exposed a compile error that was not triggered by the other tests:<br>
<br>
  sanitizer_double_allocator.h:30:11: error: use of non-static data member 'use_first_' of 'DoubleAllocator' from nested type 'DoubleAllocatorCache'<br>
        if (use_first_)<br>
            ^~~~~~~~~~<br>
<br>
The updated patch fixes this by accessing the non-static field of the enclosing class through a this pointer to one of the instances:<br>
<br>
  -      if (use_first_)<br>
  +      if (this->use_first_)<br>
<br>
The updated patch passes `check-all` with no new fails on aarch64-linux.<br>
<br>
<br>
CHANGES SINCE LAST ACTION<br>
  <a href="https://reviews.llvm.org/D60243/new/" rel="noreferrer noreferrer" target="_blank">https://reviews.llvm.org/D60243/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D60243" rel="noreferrer noreferrer" target="_blank">https://reviews.llvm.org/D60243</a><br>
<br>
Files:<br>
  compiler-rt/lib/asan/asan_allocator.cc<br>
  compiler-rt/lib/asan/asan_allocator.h<br>
  compiler-rt/lib/asan/asan_stats.cc<br>
  compiler-rt/lib/asan/asan_stats.h<br>
  compiler-rt/lib/lsan/lsan_allocator.h<br>
  compiler-rt/lib/sanitizer_common/sanitizer_allocator.h<br>
  compiler-rt/lib/sanitizer_common/sanitizer_allocator_combined.h<br>
  compiler-rt/lib/sanitizer_common/sanitizer_allocator_primary32.h<br>
  compiler-rt/lib/sanitizer_common/sanitizer_allocator_primary64.h<br>
  compiler-rt/lib/sanitizer_common/sanitizer_double_allocator.h<br>
  compiler-rt/lib/sanitizer_common/tests/sanitizer_allocator_test.cc<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" rel="noreferrer">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div></div>