[PATCH] D64476: [LLD][ELF] - Linkerscript: Fix FILL() expressions handling.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 10 07:32:37 PDT 2019
grimar marked 2 inline comments as done.
grimar added inline comments.
================
Comment at: ELF/ScriptParser.cpp:887
+ uint64_t value;
+ if (consume("(")) {
+ value = readExpr()().val;
----------------
MaskRay wrote:
> This function doesn't need any change. expect("(") below should be sufficient.
>
> readParenExpr will handle the parenthesized expression.
>
>
Hmm. Right. Not sure why I did that.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64476/new/
https://reviews.llvm.org/D64476
More information about the llvm-commits
mailing list