[PATCH] D64476: [LLD][ELF] - Linkerscript: Fix FILL() expressions handling.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 10 05:55:57 PDT 2019


MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.


================
Comment at: ELF/ScriptParser.cpp:887
+  uint64_t value;
+  if (consume("(")) {
+    value = readExpr()().val;
----------------
This function doesn't need any change. expect("(") below should be sufficient.

readParenExpr will handle the parenthesized expression.




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64476/new/

https://reviews.llvm.org/D64476





More information about the llvm-commits mailing list