[PATCH] D64407: [DWARF] Simplify constructing of DWARFAttribute. NFC.

[Igor Kudrin via Phabricator via llvm-commits]

ikudrin updated this revision to Diff 208904.
ikudrin added a reviewer: probinson.
ikudrin added a comment.

- Adjusted the initializer for `Value`.
- Removed the constructor.
- Removed the method `clear()` and replaced the only usage with `AttrValue = {}`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64407/new/

https://reviews.llvm.org/D64407

Files:
  include/llvm/DebugInfo/DWARF/DWARFAttribute.h
  lib/DebugInfo/DWARF/DWARFDie.cpp


Index: lib/DebugInfo/DWARF/DWARFDie.cpp
===================================================================
--- lib/DebugInfo/DWARF/DWARFDie.cpp
+++ lib/DebugInfo/DWARF/DWARFDie.cpp
@@ -663,7 +663,7 @@
 }
 
 DWARFDie::attribute_iterator::attribute_iterator(DWARFDie D, bool End)
-    : Die(D), AttrValue(0), Index(0) {
+    : Die(D), Index(0) {
   auto AbbrDecl = Die.getAbbreviationDeclarationPtr();
   assert(AbbrDecl && "Must have abbreviation declaration");
   if (End) {
@@ -693,7 +693,7 @@
     AttrValue.ByteSize = ParseOffset - AttrValue.Offset;
   } else {
     assert(Index == NumAttrs && "Indexes should be [0, NumAttrs) only");
-    AttrValue.clear();
+    AttrValue = {};
   }
 }
 
Index: include/llvm/DebugInfo/DWARF/DWARFAttribute.h
===================================================================
--- include/llvm/DebugInfo/DWARF/DWARFAttribute.h
+++ include/llvm/DebugInfo/DWARF/DWARFAttribute.h
@@ -27,12 +27,9 @@
   /// The debug info/types section byte size of the data for this attribute.
   uint32_t ByteSize = 0;
   /// The attribute enumeration of this attribute.
-  dwarf::Attribute Attr;
+  dwarf::Attribute Attr = dwarf::Attribute(0);
   /// The form and value for this attribute.
-  DWARFFormValue Value;
-
-  DWARFAttribute(uint32_t O, dwarf::Attribute A = dwarf::Attribute(0),
-                 dwarf::Form F = dwarf::Form(0)) : Attr(A), Value(F) {}
+  DWARFFormValue Value = DWARFFormValue();
 
   bool isValid() const {
     return Offset != 0 && Attr != dwarf::Attribute(0);
@@ -45,13 +42,6 @@
   /// Identifies DWARF attributes that may contain a reference to a
   /// DWARF expression.
   static bool mayHaveLocationDescription(dwarf::Attribute Attr);
-
-  void clear() {
-    Offset = 0;
-    ByteSize = 0;
-    Attr = dwarf::Attribute(0);
-    Value = DWARFFormValue();
-  }
 };
 
 } // end namespace llvm


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64407.208904.patch
Type: text/x-patch
Size: 1846 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190710/3ddb07d7/attachment.bin>