[PATCH] D64407: [DWARF] Simplify constructing of DWARFAttribute. NFC.

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: include/llvm/DebugInfo/DWARF/DWARFAttribute.h:34
 
-  DWARFAttribute(uint32_t O, dwarf::Attribute A = dwarf::Attribute(0),
-                 dwarf::Form F = dwarf::Form(0)) : Attr(A), Value(F) {}
+  DWARFAttribute() = default;
 
----------------
Remove this ctor since it's the same as the implicit default ctor now.


================
Comment at: include/llvm/DebugInfo/DWARF/DWARFAttribute.h:47-53
 
   void clear() {
     Offset = 0;
     ByteSize = 0;
     Attr = dwarf::Attribute(0);
     Value = DWARFFormValue();
   }
----------------
Could you remove this function, and replace the one use (in DWARFDie.cpp) with "AttrValue = {};" instead, now that default construction has the desired effect.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64407/new/

https://reviews.llvm.org/D64407