[PATCH] D63806: [PowerPC][Peephole] Combine extsw and sldi after instruction selection
Hal Finkel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 8 19:04:41 PDT 2019
hfinkel added inline comments.
================
Comment at: llvm/lib/Target/PowerPC/PPCMIPeephole.cpp:1404
+ ++NumEXTSWAndSLDICombined;
+ ToErase = &MI;
+ return true;
----------------
lkail wrote:
> hfinkel wrote:
> > Should we also erase SrcMI?
> Yes. We can erase `SrcMI` here, also we can leave it to DCE pass. I have no idea which one is preferable.
Might as well do it here.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63806/new/
https://reviews.llvm.org/D63806
More information about the llvm-commits
mailing list