[PATCH] D63806: [PowerPC][Peephole] Combine extsw and sldi after instruction selection
Kai Luo via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 8 18:45:21 PDT 2019
lkail marked an inline comment as done.
lkail added inline comments.
================
Comment at: llvm/lib/Target/PowerPC/PPCMIPeephole.cpp:1404
+ ++NumEXTSWAndSLDICombined;
+ ToErase = &MI;
+ return true;
----------------
hfinkel wrote:
> Should we also erase SrcMI?
Yes. We can erase `SrcMI` here, also we can leave it to DCE pass. I have no idea which one is preferable.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63806/new/
https://reviews.llvm.org/D63806
More information about the llvm-commits
mailing list