[PATCH] D64292: [ARM] Add support for MSVC stack cookie checking
Martin Storsjö via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Jul 6 21:53:01 PDT 2019
mstorsjo marked an inline comment as done.
mstorsjo added inline comments.
================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:15122
+ }
+ TargetLowering::insertSSPDeclarations(M);
+}
----------------
compnerd wrote:
> Would you mind flipping the condition on L15107 and doing an early return?
>
> ```
> if (!Subtarget->getTargetTriple().isWindowsMSVCEnvironment())
> return TargetLowering::insertSSPDeclarations(M);
> ```
Sure, I can do that
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64292/new/
https://reviews.llvm.org/D64292
More information about the llvm-commits
mailing list