[PATCH] D64292: [ARM] Add support for MSVC stack cookie checking

Saleem Abdulrasool via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 6 19:46:48 PDT 2019


compnerd accepted this revision.
compnerd added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:15122
+  }
+  TargetLowering::insertSSPDeclarations(M);
+}
----------------
Would you mind flipping the condition on L15107 and doing an early return?

```
if (!Subtarget->getTargetTriple().isWindowsMSVCEnvironment())
  return TargetLowering::insertSSPDeclarations(M);
```


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64292/new/

https://reviews.llvm.org/D64292





More information about the llvm-commits mailing list