[PATCH] D61907: [RISCV] Leave pcrel_hi/pcrel_lo fixup pairs unresolved

Fri Jul 5 10:06:54 PDT 2019

jrtc27 added inline comments.

================
Comment at: test/MC/RISCV/linker-relaxation.s:125
 addi t1, t1, %pcrel_lo(2b)
-# NORELAX-RELOC-NOT: R_RISCV_PCREL_LO12_I
+# NORELAX-RELOC: R_RISCV_PCREL_LO12_I bar 0x4
 # NORELAX-RELOC-NOT: R_RISCV_RELAX
----------------
asb wrote:
> asb wrote:
> > Shouldn't be this be `.Ltmp1 0x0` just like in the RELAX-RELOC case?
> Hi Lewis, did you have any thoughts on this?
Yes, it should be. It's because `RISCVMCExpr::evaluateAsRelocatableImpl` evaluates it fully to the indirected symbol since `RAB.willForceRelocations` is false, unlike the RELAX-RELOC case.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61907/new/

https://reviews.llvm.org/D61907